Page 1 of 1

Why were global.c/global.h implemented?

Posted: Sat Aug 06, 2011 9:09 pm
by Angeba
These files do not exist in ng-4.7.2. In the bloodspilot clients package they contain many
declarations and definitions of variables which are also declared/defined in other files.
This is probably very unclean. Is it nessesary to have these files?

Re: Why were global.c/global.h implemented?

Posted: Mon Aug 08, 2011 2:46 pm
by rotunda
It seems previously there was a bunch of extern definitions were in client.h. As the client code base was separated from the server code base, it was probably cleaner to move all non-static definitions to globals.{c,h}. I agree though that we should try to remove excess definitions, especially those that are accessed only within one module.