Why were global.c/global.h implemented?

Discussions related to the BloodsPilot clients
Post Reply
Angeba
Posts: 88
Joined: Sun Feb 06, 2011 11:23 pm

Why were global.c/global.h implemented?

Post by Angeba »

These files do not exist in ng-4.7.2. In the bloodspilot clients package they contain many
declarations and definitions of variables which are also declared/defined in other files.
This is probably very unclean. Is it nessesary to have these files?
rotunda
Site Admin
Posts: 77
Joined: Wed Mar 24, 2010 2:19 pm

Re: Why were global.c/global.h implemented?

Post by rotunda »

It seems previously there was a bunch of extern definitions were in client.h. As the client code base was separated from the server code base, it was probably cleaner to move all non-static definitions to globals.{c,h}. I agree though that we should try to remove excess definitions, especially those that are accessed only within one module.
Post Reply